[Dialog] Align disableOutsidePointerEvents to trapFocus prop #2849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrosousa13
requested review from
benoitgrelard,
andy-hook,
vladmoroz and
lucasmotta
as code owners
pedrosousa13
changed the title
|
Can someone take a look at this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were trying to use
forceMounton our Dialog implementation of the component. Our idea is to have the modals be in the DOM but not visible until the Trigger is clicked.Doing this, we noticed that the
trapFocusworked correctly but thedisableOutsidePointerEventsprop was addingpointer-events: noneto a lot of elements so you couldn't interact with the page.By aligning this behavior with
trapFocus, everything works as intended and the pointer event styles aren't added if the modal is closed.