Fix PostgreSQL Cidr#change?: NoMethodError: undefined method `prefix' for nil #51758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Comment on lines
28
to
31
| assert_equal false, type.changed?(nil, nil, "") | ||
| assert_equal true, type.changed?("192.168.0.0/24", nil, "") | ||
| assert_equal true, type.changed?(nil, "192.168.0.0/24", "") | ||
| assert_equal true, type.changed?("192.168.0.0/24", "192.168.0.0/25", "") |
There was a problem hiding this comment.
We probably don't need to verify equality with false/true here, can we just use assert and assert_not on these, to simplify?
There was a problem hiding this comment.
@carlosantoniodasilva Thanks for comments.
I have fixed it.
taketo1113
force-pushed
the
fix-changed-cidr2
branch
from
b341124
to
c395b99
Compare
carlosantoniodasilva
added a commit
that referenced
this pull request
May 14, 2024
PostgreSQL Cidr#change? raise an error of NoMethodError: undefined method `prefix' for nil, when creating a record with an empty value of inet/cidr column.
carlosantoniodasilva
added a commit
that referenced
this pull request
May 14, 2024
PostgreSQL Cidr#change? raise an error of NoMethodError: undefined method `prefix' for nil, when creating a record with an empty value of inet/cidr column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because fixes an error.
Steps to reproduce are below comments.
#51633 (comment)
Detail
PostgreSQL Cidr#change? raise an error of NoMethodError: undefined method `prefix' for nil, when creating a record with an empty value of inet/cidr column.
This Pull Request changes fixes the error and adds a test case.
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]