Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #50941 from andrewn617/actionable-cli" #51766

Merged

Conversation

andrewn617
Copy link
Contributor

@andrewn617 andrewn617 commented May 8, 2024

Motivation / Background

This reverts changes from #50941. After discussion on #51502 I had some offline discussion with @matthewd. While we like this idea, we agreed the implementation is not right yet. So let's revert this and we can go back to the drawing board.

Detail

Reverts d4c40b6

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the railties label May 8, 2024
@rafaelfranca rafaelfranca changed the base branch from main to 7-2-stable May 13, 2024 18:28
@rafaelfranca rafaelfranca merged commit 50f697e into rails:7-2-stable May 13, 2024
4 checks passed
@rafaelfranca rafaelfranca deleted the revert-actionable-errors-retry branch May 13, 2024 18:28
rafaelfranca added a commit that referenced this pull request May 13, 2024
Revert "Merge pull request #50941 from andrewn617/actionable-cli"
dhh pushed a commit that referenced this pull request May 14, 2024
Revert "Merge pull request #50941 from andrewn617/actionable-cli"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants