Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference the dev container guides in a comment in the production doc… #51789

Merged
merged 1 commit into from May 13, 2024
Merged

Reference the dev container guides in a comment in the production doc… #51789

merged 1 commit into from May 13, 2024

Conversation

andrewn617
Copy link
Contributor

@andrewn617 andrewn617 commented May 11, 2024 •
edited

Motivation / Background

Follow up to #51751

Detail

Now that the dev container guide is merged let's reference it in this comment to help people go in the right direction.

Additional information

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the railties label May 11, 2024
akhilgkrishnan
akhilgkrishnan approved these changes May 12, 2024
View reviewed changes
Copy link
Member

@akhilgkrishnan akhilgkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrewn617

@akhilgkrishnan akhilgkrishnan added the ready PRs ready to merge label May 12, 2024
@andrewn617 andrewn617 force-pushed the reference-devcontainer-guides-in-dockerfile branch from 6cd2661 to e3d8545 Compare May 13, 2024 18:11
@andrewn617 andrewn617 force-pushed the reference-devcontainer-guides-in-dockerfile branch from e3d8545 to eeec15c Compare May 13, 2024 18:12
@rafaelfranca rafaelfranca merged commit 66eda9c into rails:main May 13, 2024
1 of 3 checks passed
@rafaelfranca rafaelfranca deleted the reference-devcontainer-guides-in-dockerfile branch May 13, 2024 18:29
rafaelfranca added a commit that referenced this pull request May 13, 2024
@rafaelfranca
Merge pull request #51789 from Shopify/reference-devcontainer-guides-…
2568b20 
…in-dockerfile

Reference the dev container guides in a comment in the production doc…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhilgkrishnan akhilgkrishnan akhilgkrishnan approved these changes

Assignees
No one assigned
Labels
railties ready PRs ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrewn617 @akhilgkrishnan @rafaelfranca