Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry after interval time if there is an error with GenerateIndex func #45400

Conversation

rohitsakala
Copy link
Member

@rohitsakala rohitsakala commented May 7, 2024

Please see the issue for more details

Summary

  • We retry after 6 hours interval if there is an error and not retry after every 30 seconds like wrangler from GenerateFunc since GenerateFunc is the function which calls the registry. This reduces the load on the registry.

@rohitsakala rohitsakala force-pushed the decrease-the-number-of-calls-to-registry-in-oci-implementation branch 3 times, most recently from a26d7a9 to 5d23cdb Compare May 8, 2024 21:55
@rohitsakala rohitsakala marked this pull request as ready for review May 8, 2024 22:09
@rohitsakala rohitsakala force-pushed the decrease-the-number-of-calls-to-registry-in-oci-implementation branch from 5d23cdb to a3e2735 Compare May 8, 2024 22:28
logrus.Debugf("failed to create/udpate the configmap incase of 4xx statuscode for %s", clusterRepo.Name)
return o.set4xxCondition(clusterRepo, errResp, originalStatus)
}
// If there is 429 error code, then we don't reconcile further and wait for 6 hours interval
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is an error other than 429

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@rohitsakala rohitsakala force-pushed the decrease-the-number-of-calls-to-registry-in-oci-implementation branch 2 times, most recently from 85f5bd5 to 558c3bb Compare May 14, 2024 19:44
@rohitsakala rohitsakala force-pushed the decrease-the-number-of-calls-to-registry-in-oci-implementation branch from 558c3bb to be97233 Compare May 14, 2024 19:47
@rohitsakala rohitsakala merged commit 417aab8 into rancher:release/v2.9 May 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants