Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2.9] Fix delete init node for RKE2 clusters #45413

Merged
merged 1 commit into from May 14, 2024
Merged

[v2.9] Fix delete init node for RKE2 clusters #45413

merged 1 commit into from May 14, 2024

Conversation

markusewalker
Copy link
Contributor

@markusewalker markusewalker marked this pull request as draft May 7, 2024 22:42
slickwarren
slickwarren reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@slickwarren slickwarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions about the removal of some lines

go.mod Outdated Show resolved Hide resolved
tests/v2/validation/deleting/delete_init_machine_test.go Outdated Show resolved Hide resolved
tests/v2/validation/deleting/delete_init_machine_test.go Show resolved Hide resolved
@markusewalker markusewalker force-pushed the markusv29/task-1313 branch 3 times, most recently from 9f2612d to f315a73 Compare May 7, 2024 23:54
slickwarren
slickwarren reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@slickwarren slickwarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm: pending shepherd merge for final approval

susesgartner
susesgartner approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@susesgartner susesgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markusewalker markusewalker force-pushed the markusv29/task-1313 branch 2 times, most recently from 455f769 to 10d3ff1 Compare May 9, 2024 22:35
@markusewalker markusewalker marked this pull request as ready for review May 9, 2024 22:35
This was referenced May 9, 2024
Merged
Merged
@markusewalker markusewalker mentioned this pull request May 10, 2024
Closed
@markusewalker markusewalker marked this pull request as draft May 13, 2024 19:00
@markusewalker markusewalker force-pushed the markusv29/task-1313 branch 2 times, most recently from 0118c1e to 0158ccc Compare May 13, 2024 20:28
@markusewalker markusewalker marked this pull request as ready for review May 13, 2024 20:28
@markusewalker markusewalker merged commit c2efb2b into rancher:release/v2.9 May 14, 2024
2 checks passed
@markusewalker markusewalker deleted the markusv29/task-1313 branch May 14, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slickwarren slickwarren slickwarren approved these changes

@Josh-Diamond Josh-Diamond Josh-Diamond approved these changes

@susesgartner susesgartner Awaiting requested review from susesgartner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markusewalker @slickwarren @Josh-Diamond @susesgartner