[2.9] Add build system's values to Drone's targets via build-args #45419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Drone doesn't run all the scripts intended to be run on release. Because of this, images built by Drone and pushed to registries don't have some of the environment variables needed for Rancher at run time. Because Drone will soon be removed in favor of GitHub Actions, this commit simply adds the environment variables as build-args inline, instead of fixing the Drone pipeline steps and the scripts it runs.
maxsokolovsky
changed the title
MbolotSuse
reviewed
May 8, 2024
.drone.yml
Outdated
| @@ -608,6 +616,9 @@ steps: | |||
| build_args: | |||
| - ARCH=arm64 | |||
| - VERSION=${DRONE_BRANCH/release\//}-${DRONE_COMMIT}-head | |||
| - CATTLE_RANCHER_WEBHOOK_VERSION=104.0.0+up0.5.0-rc8 | |||
There was a problem hiding this comment.
Rather than adding the hardcoded values here, can we instead use build_args_from_env and maybe use command: or something similar to source scripts/package-env?
There was a problem hiding this comment.
Let me look into Drone's docs for that. This would be a much better fix - a release captain won't need to update these values then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #45418
Problem
Currently, Drone doesn't run all the scripts intended to be run on release. Specifically, it doesn't run
ciin all its targets. Because of this, images built by Drone and pushed to registries don't run some of the necessary scripts and thus don't have some of the environment variables needed for Rancher at run time.Solution
Because Drone will soon be removed in favor of GitHub Actions, this commit simply adds the environment variables as build-args inline, instead of fixing the Drone pipeline steps and the ensuing it runs the script populating the environment variables defined by the build system.
Testing
Engineering Testing
Manual Testing
Automated Testing
Summary: TODO
QA Testing Considerations
Regressions Considerations
TODO
Existing / newly added automated tests that provide evidence there are no regressions: