Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.8] For clusterRepo updation fails for rancher bundle, we don't error #45432

Conversation

rohitsakala
Copy link
Member

@rohitsakala rohitsakala commented May 9, 2024

Backport of #45280
Please see the issue for more info.

Summary

  • We go back to the previous implementation where if it is a bundled repository, we don't error. The reason is unknown but the code was written in such a way.
  • We report an error if the branch in invalid as an exception

@rohitsakala rohitsakala marked this pull request as ready for review May 9, 2024 20:10
@rohitsakala rohitsakala added this to the v2.8-Next2 milestone May 9, 2024
@rohitsakala rohitsakala merged commit a5c7816 into rancher:release/v2.8 May 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants