Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.9] pin rancher capi chart version #45438

Open
wants to merge 3 commits into
base: release/v2.9
Choose a base branch
from

Conversation

vardhaman22
Copy link
Contributor

@vardhaman22 vardhaman22 commented May 10, 2024

Issue:

#45099

  1. added a setting CATTLE_RANCHER_PROVISIONING_CAPI_VERSION similar to CATTLE_RANCHER_WEBHOOK_VERSION
  2. updated unit test cases for CAPI chart and made them similar to rancher-webhook tests.
  3. added exact version setting for capi in controller.

Problem

capi chart was being auto upgraded to newer version and if there are some breaking changes in the new CAPI chart it was breaking an older running rancher instance.

Solution

pin CAPI chart to a fix version in rancher through settings.

Testing

  1. rancher docker install and checking the CAPI chart version.
    --> successful chart version is same as the one specified in build.yaml 103.2.0+up0.0.1
    capi-pinning_1

  2. rancher docker install with env variable to override the chart version to 103.0.0+up0.0.1
    --> successful chart version is same as the env variable passed.
    capi_pinning_2

Engineering Testing

Manual Testing

Automated Testing

  • Test types added/modified:
    • Unit
    • Integration (Go Framework)
    • Integration (v2prov Framework)
    • Validation (Go Framework)
    • Other - Explain: EXPLAIN
    • None
    • REMOVE NOT APPLICABLE BULLET POINTS ABOVE
  • If "None" - Reason: EXPLAIN THE REASON
  • If "None" - GH Issue/PR: LINK TO GH ISSUE/PR TO ADD TESTS

Summary: TODO

QA Testing Considerations

Regressions Considerations

TODO

Existing / newly added automated tests that provide evidence there are no regressions:

  • TODO

@vardhaman22 vardhaman22 changed the title Pin rancher capi chart pin rancher capi chart version May 10, 2024
@vardhaman22 vardhaman22 marked this pull request as ready for review May 16, 2024 13:41
@vardhaman22 vardhaman22 changed the title pin rancher capi chart version [v2.9] pin rancher capi chart version May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant