chore(deps)!: update termion requirement from 3.0 to 4.0 #1106
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
dependencies
dependabot
bot
requested review from
joshka,
kdheepak,
Valentin271 and
EdJoPaTo
as code owners
orhun
approved these changes
May 13, 2024
There was a problem hiding this comment.
Looks good to merge: https://gitlab.redox-os.org/redox-os/termion/-/blob/master/CHANGELOG.md
Not sure if it is too breaking though.
kdheepak
approved these changes
May 13, 2024
Guess that should wait till after the span bug fix release. |
dependabot
bot
force-pushed
the
dependabot/cargo/termion-4.0
branch
from
496792f
to
fcec1bc
Compare
dependabot
bot
force-pushed
the
dependabot/cargo/termion-4.0
branch
from
fcec1bc
to
7d72ee6
Compare
joshka
approved these changes
May 25, 2024
From the Changelog:
So this is breaking and would potentially break ratatui users, and should be noted in the breaking changes doc and commit |
|
@dependabot rebase |
dependabot
bot
force-pushed
the
dependabot/cargo/termion-4.0
branch
from
7d72ee6
to
0ebf5c3
Compare
|
@dependabot rebase |
joshka
force-pushed
the
dependabot/cargo/termion-4.0
branch
2 times, most recently
from
cf548a7
to
323b8de
Compare
joshka
force-pushed
the
dependabot/cargo/termion-4.0
branch
from
30c8f4a
to
f2b50bb
Compare
joshka
changed the title
joshka
added a commit
that referenced
this pull request
Jun 3, 2024
Updates the requirements on termion to permit the latest version. Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> BREAKING CHANGE: Changelog: <https://gitlab.redox-os.org/redox-os/termion/-/blob/master/CHANGELOG.md> A change is only necessary if you were matching on all variants of the `MouseEvent` enum without a wildcard. In this case, you need to either handle the two new variants, `MouseLeft` and `MouseRight`, or add a wildcard. Co-authored-by: Josh McKinney <joshka@users.noreply.github.com>
|
I forced pushed a change that added the ! to the title to make sure it shows up in the changelog correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on termion to permit the latest version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)BREAKING CHANGE: Changelog: https://gitlab.redox-os.org/redox-os/termion/-/blob/master/CHANGELOG.md
A change is only necessary if you were matching on all variants of the
MouseEventenum without awildcard. In this case, you need to either handle the two new variants,
MouseLeftandMouseRight, or add a wildcard.