Add PHP >= 8 support + updated tests and workflow. #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow manual workflow run
Update comments
Remove workflow_dispatch
Remove unnecessary include from HttpServer
…d a better solution)
… maintaining PHP < 7.0 support.
Add http-foundation 6.0 back
Disable scheduled action run
|
Hey there, @cboden |
|
why php5.4 its useless... just drop php < 8 |
Agreed, however it's not my project so keeping/dropping support isn't up to me, I'm just getting it working again. |
|
@josh-gaby awesome work, hopefully it can get reviewed and merged soon! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes updated tests and workflow for running tests on PHP 5.4 -> 8.2
Also, due to symfony/http-foundation v6+ including return types and Ratchet supporting PHP < 7.0, there is a not very nice hack involving maintaining two versions of two classes (VirtualProxy and VirtualSessionStorage). This is currently working and passing all tests but definitly needs a better solution long-term.