-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimized Swordsman tutorial quest #8251
base: master
Are you sure you want to change the base?
Conversation
Daegaladh
commented
Apr 13, 2024
•
edited
edited
- Addressed Issue(s): N/A
- Server Mode: Both
- Description of Pull Request: Several optimizations to Swordsman tutorial quest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Quick review)
mes "should go second?"; | ||
next; | ||
.@select = select(implode(.@menu$, ":")) - 1; | ||
.@code$[1] = inarray(.@names_array$, .@menu$[.@select]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inarray return int it's strange to store it in str
.@code$[1] = inarray(.@names_array$, .@menu$[.@select]); | ||
deletearray .@menu$[.@select], 1; | ||
mes "[Dequ'ee]"; | ||
mes .@names_array$[.@code$[1]] +"'s...?"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
index can't be string in this engine
@@ -2068,7 +1428,8 @@ geffen,154,143,3 script Dequ'ee 734,{ | |||
mes "be the message I'm supposed to receive from Shurack. I need his exact message or I can't send"; | |||
mes "a response..."; | |||
close; | |||
case 2: | |||
} | |||
else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me else / else if
should only be used if the code continue after the previous condition.