Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with react.dev @ 93177e6c #746

Merged
merged 22 commits into from
Apr 10, 2024
Merged

Sync with react.dev @ 93177e6c #746

merged 22 commits into from
Apr 10, 2024

Conversation

react-translations-bot
Copy link
Collaborator

@react-translations-bot react-translations-bot commented Apr 8, 2024

rickhanlonii and others added 20 commits March 4, 2024 17:28
It seems like these localhost references were being stripped out anyway,
so this isn't a bugfix but just a small cleanup.
This PR adds a new Rules of React reference section that covers the major rules that help developers author idiomatic React apps.

---------

Co-authored-by: Sathya Gunasekaran <gsathya.ceg@gmail.com>
Small change to match the sidebar order.
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Co-authored-by: Allison Strandberg <55810428+allison-strandberg@users.noreply.github.com>
This example contains a list of person objects, but only the first 3 have id properties. This appears to be a mistake; in the next use of the list all 5 person objects have this property, but it is not changed as part of an instructive exercise.

This change makes the final two with objects consistent with the remainder of the list.
`an text area` -> `a text area`
`an discussion` -> `a discussion`
…6728)

Signed-off-by: Faridul Islam <foridpathan45@gmail.com>
Noticed this randomly and couldn't unsee it, so here's a quick PR to
fix.
Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
legacy-ja-reactjs-org ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 1:07pm

Copy link

github-actions bot commented Apr 10, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/[[...markdownPath]] 84.31 KB (🟡 +95 B) 188.23 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Member

@smikitky smikitky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koba04 よろしくお願いしますー

@smikitky
Copy link
Member

ちなみに effect や transition や action を大文字にするならまず何より state を大文字にしなきゃおかしいのではと内心思いつつも黙っていたのですが、ついに reactjs/react.dev#6713 で本当に本文中の state を全部 State に変えるというマージするときに気が遠くなりそうな作業が進行中みたいですね…

Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1点だけ以前からあったtypoの修正しました 🙏

src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
Co-authored-by: Toru Kobayashi <koba0004@gmail.com>
@smikitky smikitky merged commit 186f10a into main Apr 10, 2024
5 checks passed
@smikitky smikitky deleted the sync-93177e6c branch April 10, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet