Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer rule severity for React Compiler eslint plugin #6870

Merged
merged 1 commit into from
May 16, 2024

Conversation

SpanishPear
Copy link
Contributor

What is this PR?

Updates the eslint-plugin-react-compiler docs to use severity of "error" rather than severity of 2

Why is this PR?

Using "off", "warn", "error" for eslint rule severity has been supported for many years now - I think this helps improve the readability :)

I completely forgot what rule: 2 meant - had to look it up!
https://eslint.org/docs/latest/use/configure/rules

Using "off", "warn", "error" has been supported for many years now - I think this helps improve the readability :) 

I completely forgot what rule: 2 meant - had to find it at 

https://eslint.org/docs/latest/use/configure/rules
Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 4:52am
react-dev ✅ Ready (Inspect) Visit Preview May 16, 2024 4:52am

@facebook-github-bot
Copy link
Collaborator

Hi @SpanishPear!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@SpanishPear
Copy link
Contributor Author

SpanishPear commented May 16, 2024

Signed the CLA 🕐

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@poteto
Copy link
Member

poteto commented May 16, 2024

thanks!

@poteto poteto merged commit 8d69e6e into reactjs:main May 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants