Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using SocketAddress proxies instead of just InetSocketAddress #3243

Merged
merged 5 commits into from
May 15, 2024

Conversation

AlexProgrammerDE
Copy link
Contributor

This commit adds new socketAddress methods and tries to keep backwards compat for users using the old address methods, which are deprecated. I'd recommend removing socketAddress and renaming it back to address on the next major release.

Fixes #3242

This commit adds new socketAddress methods and tries to keep backwards compat for users using the old address methods, which are deprecated. I'd recommend removing socketAddress and renaming it back to address on the next major release.

Fixes reactor#3242
@violetagg violetagg added this to the 1.2.0-M3 milestone May 14, 2024
@violetagg violetagg added the type/enhancement A general enhancement label May 14, 2024
@violetagg violetagg self-requested a review May 14, 2024 09:18
@AlexProgrammerDE
Copy link
Contributor Author

I guess the error lies in that new methods to the interface were added?

@AlexProgrammerDE
Copy link
Contributor Author

Maybe this can be fixed by keeping address unimplemented and the socketAddress method defaulting to delegating to address. And then the implementing builder class overrides socketAddress and implements address as the one delegating to socketAddress. Seems a bit unnecessary though since this class is only supposed to be implemented by the builder class.

@violetagg
Copy link
Member

what do you think about this?

		default Builder socketAddress(SocketAddress address) {
			throw new UnsupportedOperationException();
		}

		default Builder socketAddress(Supplier<? extends SocketAddress> addressSupplier) {
			throw new UnsupportedOperationException();
		}

@AlexProgrammerDE
Copy link
Contributor Author

Sure, lets do it

@AlexProgrammerDE
Copy link
Contributor Author

Should pass checks now and is ready for review.

@AlexProgrammerDE
Copy link
Contributor Author

It seems like the build failed because of unrelated reasons with ssl stuff on windows. I've merged now upstream into my branch and I hope the build passes now.

@AlexProgrammerDE
Copy link
Contributor Author

AlexProgrammerDE commented May 14, 2024

Seems like a request failure to maven central broke the build this time:
image
Maybe try rerunning that failed test.

@AlexProgrammerDE
Copy link
Contributor Author

AlexProgrammerDE commented May 14, 2024

image
Seems like there are still errors that aren't maven central connection issues. I doubt they are related to the content of this PR though.

@violetagg
Copy link
Member

Failed tests on Mac OS CI are not related

Copy link
Member

@violetagg violetagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexProgrammerDE Thanks for the PR!

@reactor/netty-team PTAL

@violetagg violetagg requested a review from a team May 15, 2024 07:11
Copy link
Member

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexProgrammerDE

Nice, thanks for the PR!

+1

@violetagg violetagg merged commit f390e3f into reactor:main May 15, 2024
13 of 14 checks passed
@violetagg violetagg changed the title Allow using SocketAddress proxies instead of just InetSocketAddress Allow using SocketAddress proxies instead of just InetSocketAddress May 15, 2024
@AlexProgrammerDE AlexProgrammerDE deleted the proxy-socketaddress branch May 15, 2024 10:02
violetagg added a commit that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support SocketAddress for proxies
3 participants