[NETCFGX] Improve Romanian (ro-RO) translation #6863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc @reactos/lang-romanian |
binarymaster
reviewed
May 9, 2024
JoachimHenze
reviewed
May 9, 2024
| CONTROL "Folosește adresa &DNS următoare", IDC_FIXEDDNS, "BUTTON", BS_AUTORADIOBUTTON, 14, 145, 152, 12 | ||
| LTEXT "Server DNS p&referat:", -1, 14, 161, 135, 8 | ||
| CONTROL "Se o&bţine automat adresa de server DNS", IDC_AUTODNS, "BUTTON", BS_AUTORADIOBUTTON | WS_GROUP | WS_TABSTOP, 14, 129, 210, 12 | ||
| CONTROL "S&e utilizează adresa de server DNS următoare:", IDC_FIXEDDNS, "BUTTON", BS_AUTORADIOBUTTON, 14, 145, 152, 12 |
There was a problem hiding this comment.
Are you sure this ends with a : ?
There was a problem hiding this comment.
Yes, I'm sure. Here is the proof.
JoachimHenze
reviewed
May 9, 2024
| CONTROL "Adresă IP p&rivată obținută automat", IDC_USEDHCP, "BUTTON", BS_AUTORADIOBUTTON | WS_GROUP | WS_TABSTOP, 14, 40, 210, 12 | ||
| CONTROL "Configurată &manual", IDC_NODHCP, "BUTTON", BS_AUTORADIOBUTTON, 14, 55, 90, 12 | ||
| CONTROL "Ad&resă privată IP automată", IDC_USEDHCP, "BUTTON", BS_AUTORADIOBUTTON | WS_GROUP | WS_TABSTOP, 14, 40, 210, 12 | ||
| CONTROL "&Configurat de utilizator", IDC_NODHCP, "BUTTON", BS_AUTORADIOBUTTON, 14, 55, 90, 12 |
There was a problem hiding this comment.
Please attach a pic-preview of the ros dlg for this line so that we can see we'll have no cutoff with the longer string and the 90 width.
JoachimHenze
reviewed
May 9, 2024
JoachimHenze
reviewed
May 9, 2024
dll/win32/netcfgx/lang/ro-RO.rc
Outdated
| PUSHBUTTON "A&daugă", IDC_UDP_ADD, 115, 141, 50, 14, WS_TABSTOP | ||
| PUSHBUTTON "E&limină", IDC_UDP_DEL, 115, 161, 50, 14, WS_TABSTOP | ||
| PUSHBUTTON "Adăugare…", IDC_UDP_ADD, 115, 141, 50, 14, WS_TABSTOP | ||
| PUSHBUTTON "E&liminare", IDC_UDP_DEL, 115, 161, 50, 14, WS_TABSTOP | ||
| GROUPBOX "", -1, 205, 30, 90, 150 | ||
| CONTROL "Permite tot I&P", IDC_IP_ALLOW_ALL, "BUTTON", BS_AUTORADIOBUTTON | WS_GROUP | WS_TABSTOP, 215, 30, 70, 12 |
There was a problem hiding this comment.
accelerator collision of "Permite tot I&P" with "Se &permit toate"
JoachimHenze
requested changes
May 9, 2024
Co-authored-by: Joachim Henze <joachim.henze@reactos.org>
binarymaster
reviewed
May 9, 2024
|
Thank you @binarymaster! I didn't notice my mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attendum to #6517
Ignore the typo from the first commit name. I forgot a f letter.