-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MSI] CORE-18707 workaround. Allow MSI under ROS amd64 to continue when GetSystemWow64DirectoryW is called #6887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgotten changes there too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, although it is a workaround. But if it helps you guys for now, why not. Thanks for using the preprocessor to make sure, that it definitely won't break anything for 32bit builds. Thumbs up.
becc95d
to
1139f56
Compare
1139f56
to
3992e32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big fan of the java style braces, but there's been too much whitespace nitpicking on this PR already.
…SystemWow64DirectoryW is called [MSI] Fix minor indentation and spaces before brackets. [MSI] Minor fixes and correctly reporting ERR instead of WARN [MSI] Fixing a warning and the whitespaces [MSI] Minor fix whitespaces [MSI] Fix minor typo
3992e32
to
271f4b3
Compare
The outer-curly-braces do at least limit the scope of the |
[MSI] CORE-18707 hack. Allow MSI under ROS amd64 to continue when GetSystemWow64DirectoryW is called
Purpose
Workaround (with a hack) a temporary situation since we have the WOW64 unimplemented (neither GetSystemWow64DirectoryW).
JIRA issue: CORE-18707
Proposed changes
TODO