[NETSHELL] LanStatusUI: Fix the Network Connection Systray icon opening several dialog windows when cable isn't connected

[Connierollstheball]

Purpose

Prevents the Icon from opening up more than one window + Changes the window that's opened from the Connection Properties dialog to the Network Connections Folder (like in Server '03, which is the expected result as per the JIRA issue).

JIRA issue: CORE-19562

Proposed changes

• Changes the window being opened by the Disconnected Systray icon from the Connection Properties Dialog for the respective Adapter to the Network Connections Folder.
• Prevents the icon from opening the window more than once (if it's already open, find it and bring it to the top instead).

[whindsaks]

This makes assumptions about how Explorer formats its window titles? IShellWindows is a lot more work so I guess we can let it slide for now.

[GeoB99]

Hello,
Thanks for your interest in ReactOS!
We ask our contributors to use their full real name when committing.
Please amend your commit with your full name, and update this PR.

To change this for future PR's, you can update it for globally (for the system):

git config --global user.name "Your Name"
git config --global user.email you@example.com

Or just for the current repository:

git config user.name "Your Name"
git config user.email you@example.com

Also please update your name in GitHub profile settings.

Regards.
GeoB99

[Connierollstheball]

I should've sent this when I actually did the commits yesterday, but everything should be okay now.
Besides that, I'll wait until CSIDL_CONNECTIONS is fixed by someone else and then I'll also implement the ShellExecuteEx thingy.

[whindsaks]

I'll wait until CSIDL_CONNECTIONS is fixed

You may continue now.

[HBelusca]

Suggested change

	LoadStringW(netshell_hInstance, IDS_NETWORKCONNECTION, buffer, _countof(buffer));
	HWND hWndProp = FindWindow(NULL, buffer);
	/* If the window is already opened, prevent it from opening again */
	if (hWndProp != NULL)
	/* If the window is already opened, prevent it from opening again */
	LoadStringW(netshell_hInstance, IDS_NETWORKCONNECTION, buffer, _countof(buffer));
	HWND hWndProp = FindWindow(NULL, buffer);
	if (hWndProp)

[HBelusca]

If the window is already opened, prevent it from opening again

Granted, the way it is currently done is sensitive to the current UI language being used.

[whindsaks]

I think shell32 is supposed to check IShellWindows to see if the PIDL is already open somewhere when the reuse windows option is on. I don't think shdocvw implements the window list yet so the hack this PR is using is good enough for now.

[tkreuzer]

Code lgtm, but it needs to be sqashed into one commit and meet our standards for commit mesages.
For @Connierollstheball: You can do that yourself or ask for a merger to do so.
For anyone who wants to merge this: make sure to squash and fix the commit message, then you can ignore this request for change.

[Connierollstheball]

I'll just let a merger (I don't know who exactly I could ask in particular for this) do whatever needs to be done so this PR can be merged.

[GeoB99]

You still haven't amended your PR to use your real name.

Please follow our contribution guidelines if you want your patch to get shipped, otherwise it won't get accepted. Thanks for your understanding.

[Connierollstheball]

Sorry, I realised I missed a few steps when I was changing my git name to my full name and ammending it to the PR 😅
Everything should actually be good to go now, I made sure to follow everything correctly when updating this to my full name.