Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NOTEPAD] Add Korean (ko-KR) translation #6907

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

VenusGirl
Copy link

Korean

@katahiromz katahiromz changed the title Korean [NOTEPAD] Add Korean (ko-KR) translation May 18, 2024
@katahiromz
Copy link
Contributor

Welcome to ReactOS development.
Thank you for contribution.

At first, please read carefully the following articles:

https://github.com/reactos/reactos/blob/master/CONTRIBUTING.md

https://reactos.org/wiki/Translation_Introduction

https://reactos.org/wiki/RC_File_Standards

@katahiromz
Copy link
Contributor

Do you agree with it?

Copy link
Author

@VenusGirl VenusGirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify Font

@katahiromz
Copy link
Contributor

Do you agree?

@VenusGirl
Copy link
Author

Yes

@binarymaster binarymaster added the TRANSLATION For translation and localization PRs label May 18, 2024
@binarymaster binarymaster added this to New PRs in ReactOS PRs via automation May 18, 2024
Copy link
Author

@VenusGirl VenusGirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed translation of untranslated strings

@katahiromz
Copy link
Contributor

Can you edit this file?
base/applications/notepad/rsrc.rc

@VenusGirl
Copy link
Author

VenusGirl commented May 18, 2024

Add Korean to rsrc.rc

#ifdef LANGUAGE_KO_KR
#include "lang/ko-KR.rc"

@binarymaster
Copy link
Member

Cc @manatails for review.

Also wanted to ping Luke Luo, but he's deleted.

@binarymaster binarymaster mentioned this pull request May 18, 2024
Add Korean
@katahiromz
Copy link
Contributor

The tests are passed. Please wait patiently for review.

By the way, can you tell us your full name?
Your name is required for contribution.

@VenusGirl
Copy link
Author

I would like to have the same VenusGirl as the contributor's name in Risoh Editor.

Copy link
Member

@binarymaster binarymaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your interest in ReactOS!
We ask our contributors to use their full name when committing.
Please amend your commit with your full name, and update this PR.

To change this for future PR's, you can update it for globally (for the system):

git config --global user.name "Your Name"
git config --global user.email you@example.com

Or just for the current repository:

git config user.name "Your Name"
git config user.email you@example.com

Also please set up your GitHub account accordingly, so maintainers can use Squash & Merge button without getting the author field modified back to nickname by GitHub, it's done in two steps:

  1. Set your full name in GitHub profile settings (it should match your user.name setting)
  2. Uncheck Keep my email addresses private in GitHub email settings (addressed now)

Regards,

base/applications/notepad/lang/ko-KR.rc Outdated Show resolved Hide resolved
ReactOS PRs automation moved this from New PRs to WIP / Waiting on contributor May 18, 2024
VenusGirl and others added 2 commits May 19, 2024 11:30
Co-authored-by: Stanislav Motylkov <x86corez@gmail.com>
Copy link
Author

@VenusGirl VenusGirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix...

Copy link

@manatails manatails left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few modifications to make the translation more coherent.

base/applications/notepad/lang/ko-KR.rc Show resolved Hide resolved
base/applications/notepad/lang/ko-KR.rc Show resolved Hide resolved
base/applications/notepad/lang/ko-KR.rc Show resolved Hide resolved
base/applications/notepad/lang/ko-KR.rc Show resolved Hide resolved
base/applications/notepad/lang/ko-KR.rc Show resolved Hide resolved
* PROJECT: ReactOS Notepad
* LICENSE: LGPL-2.1-or-later (https://spdx.org/licenses/LGPL-2.1-or-later)
* PURPOSE: Korean resource file
* TRANSLATOR: Copyright 2024 VenusGirl <venusgirl@outlook.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still has to be your real name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TRANSLATION For translation and localization PRs
Projects
ReactOS PRs
  
WIP / Waiting on contributor
5 participants