[SHELL32] brfolder.cpp: Code formatting and refactoring #6909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
shell
katahiromz
changed the title
katahiromz
commented
May 19, 2024
katahiromz
force-pushed
the
brsfolder-formatting
branch
from
621e996
to
e869519
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I'm going to review this during this week. |
katahiromz
changed the title
katahiromz
force-pushed
the
brsfolder-formatting
branch
from
7884f37
to
73b5fbd
Compare
HBelusca
reviewed
May 22, 2024
There was a problem hiding this comment.
I don't see any obvious problems here but I would strongly suggest the following, in order to ease diffs and review:
- in the first commit, do all the whitespace/comments/brackets/code-style changes ONLY;
- in the second commit, do all the refactoring (renamings of structs, variables, and usage of COM/ATL helpers etc.)
JIRA issue: CORE-17340
Modernize source code. Improve readability and reduce confusing. JIRA issue: CORE-17340 - Rename browse_info as BrsFolder. - Rename TV_ITEMDATA as BrsItemData. - Rename InsertTreeViewItem as BrsFolder_InsertItem. - Rename InitializeTreeView as BrsFolder_InitTreeView. - Rename GetIcon as BrsFolder_GetIcon. - Rename GetNormalAndSelectedIcons as BrsFolder_GetIconPair. - Rename GetName as BrsFolder_GetName. - Fix some confusing and/or non-standard variable names. - Use ATL to simplify logics.
katahiromz
force-pushed
the
brsfolder-formatting
branch
from
7ba87cb
to
1cd85e6
Compare
|
@HBelusca Done. |
and rename BrsItemData as BrItemData to reduce binary size of Debug version. JIRA issue: CORE-17340
katahiromz
changed the title
JoachimHenze
approved these changes
May 23, 2024
HBelusca
added
no squash merge
HBelusca
approved these changes
May 24, 2024
1 task
katahiromz
added a commit
that referenced
this pull request
May 25, 2024
Follow-up of #6909 (af03438). Fix assertions and exceptions of CComPtr and CComHeapPtr. JIRA issue: CORE-17340 - Don't use AddRef, Release, and Attach methods against CComPtr template class. Simply use assignment. - Fix the 3rd parameter of three IShellFolder::GetAttributesOf method calls. It had referenced CHeapPtr::operator&.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Modernize source code. Improve readability and reduce confusing.
JIRA issue: CORE-17340
Proposed change
brsfolder.cppasbrfolder.cpp.browse_infoasBrFolder.TV_ITEMDATAasBrItemData.InsertTreeViewItemasBrFolder_InsertItem.InitializeTreeViewasBrFolder_InitTreeView.GetIconasBrFolder_GetIcon.GetNormalAndSelectedIconsasBrFolder_GetIconPair.GetNameasBrFolder_GetName.TODO