Move dashboard API filter fields to model queryset filter fields #11330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves a lot of dashboard JS/API logic into our standard FilterSet instances: - Project listing filter field - Version listing filter field - Build list version listing filter field To accomplish this, a few helper classes were added for making the fields easier to work with and display. Template and JS were updated in - readthedocs/ext-theme#351
humitos
approved these changes
May 21, 2024
| @@ -36,7 +37,13 @@ class BuildListFilter(FilterSet): | |||
| ) | |||
|
|
|||
| # Attribute filter fields | |||
| version = CharFilter(field_name="version__slug", widget=HiddenInput) | |||
| version__slug = FilteredModelChoiceFilter( | |||
There was a problem hiding this comment.
I like this pattern using model__field 👍🏼
Comment on lines
+106
to
+108
| def __init__(self, *args, **kwargs): | ||
| super().__init__(*args, **kwargs) | ||
|
|
There was a problem hiding this comment.
Suggested change
| def __init__(self, *args, **kwargs): | |
| super().__init__(*args, **kwargs) |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves a lot of dashboard JS/API logic into our standard FilterSet
instances:
To accomplish this, a few helper classes were added for making the
fields easier to work with and display.
Template and JS were updated in