-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RechartsWrapper event tests, and role=application #4555
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #4555 +/- ##
==========================================
+ Coverage 95.66% 95.72% +0.06%
==========================================
Files 117 117
Lines 22462 22477 +15
Branches 3082 3095 +13
==========================================
+ Hits 21488 21516 +28
+ Misses 968 955 -13
Partials 6 6 ☔ View full report in Codecov by Sentry. |
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
<RechartsWrapper | ||
className={className} | ||
width={width} | ||
// Sunburst doesn't support `style` property, why? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure it could, it's the newest chart
Description
Adding a couple of tests before I go ahead and mess with the implementation. I will try to add also tests for the payloads once I make sense of what's going on.
I also followed up on @julianna-langston advice from #4545 (comment) and I added a role='application' to all charts.
Related Issue
#4549
Motivation and Context
tests and a11y
How Has This Been Tested?
npm test
Screenshots (if appropriate):
Types of changes
Checklist: