Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RechartsWrapper event tests, and role=application #4555

Merged
merged 5 commits into from
May 20, 2024

Conversation

PavelVanecek
Copy link
Collaborator

Description

Adding a couple of tests before I go ahead and mess with the implementation. I will try to add also tests for the payloads once I make sense of what's going on.

I also followed up on @julianna-langston advice from #4545 (comment) and I added a role='application' to all charts.

Related Issue

#4549

Motivation and Context

tests and a11y

How Has This Been Tested?

npm test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a storybook story or extended an existing story to show my changes

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.72%. Comparing base (6a9029a) to head (c75de78).

Additional details and impacted files
@@            Coverage Diff             @@
##              3.x    #4555      +/-   ##
==========================================
+ Coverage   95.66%   95.72%   +0.06%     
==========================================
  Files         117      117              
  Lines       22462    22477      +15     
  Branches     3082     3095      +13     
==========================================
+ Hits        21488    21516      +28     
+ Misses        968      955      -13     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julianna-langston
Copy link
Contributor

lgtm

Copy link
Member

@ckifer ckifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

<RechartsWrapper
className={className}
width={width}
// Sunburst doesn't support `style` property, why?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure it could, it's the newest chart

test/cartesian/Area.spec.tsx Show resolved Hide resolved
@ckifer ckifer merged commit d63c6a8 into recharts:3.x May 20, 2024
5 checks passed
@PavelVanecek PavelVanecek deleted the main-wrapper-component-2 branch May 20, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants