Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move function inRange to ChartUtils #4556

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

PavelVanecek
Copy link
Collaborator

Description

So that it no longer reads this.props and this.state directly.

Related Issue

#4549

Motivation and Context

I want to reuse this function from Redux selector so I need it to be independent from generateCategoricalChart this.

How Has This Been Tested?

npm test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a storybook story or extended an existing story to show my changes

I want to reuse this function from Redux selector later so I need it to be independent from generateCategoricalChart
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.66%. Comparing base (6a9029a) to head (181d841).

Additional details and impacted files
@@           Coverage Diff           @@
##              3.x    #4556   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files         117      117           
  Lines       22462    22483   +21     
  Branches     3082     3082           
=======================================
+ Hits        21488    21509   +21     
  Misses        968      968           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ckifer ckifer merged commit 24f8a95 into recharts:3.x May 20, 2024
5 checks passed
@PavelVanecek PavelVanecek deleted the inrange-move branch May 20, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants