Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for SUNSUBSCRIBE #2759 #2851

Merged
merged 2 commits into from
May 20, 2024
Merged

Add support for SUNSUBSCRIBE #2759 #2851

merged 2 commits into from
May 20, 2024

Conversation

atakavci
Copy link
Collaborator

Closes/Fixes #2759

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes

mp911de
mp911de reviewed May 13, 2024
View reviewed changes
Copy link
Collaborator

@mp911de mp911de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments about minor items. Looks otherwise pretty good to me.

src/main/java/io/lettuce/core/pubsub/RedisPubSubListener.java Show resolved Hide resolved
src/test/java/io/lettuce/core/pubsub/RedisPubSubAsyncCommandsImplUnitTests.java Outdated Show resolved Hide resolved
@atakavci atakavci self-assigned this May 14, 2024
tishun
tishun approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atakavci atakavci merged commit 76efb8b into redis:main May 20, 2024
4 checks passed
@tishun tishun added the type: enhancement A general enhancement label Jun 6, 2024
@tishun tishun modified the milestones: 7.0.0.RELEASE, 6.4.0.RELEASE Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de mp911de left review comments

@tishun tishun tishun approved these changes

@gerzse gerzse Awaiting requested review from gerzse

Assignees

@atakavci atakavci

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
6.4.0.RELEASE
Development

Successfully merging this pull request may close these issues.

Add support for SUNSUBSCRIBE
3 participants
@atakavci @mp911de @tishun