Fix evict.c mem_freed variable init #13096
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundb
reviewed
Feb 28, 2024
| @@ -545,7 +545,7 @@ int performEvictions(void) { | |||
|
|
|||
| int keys_freed = 0; | |||
| size_t mem_reported, mem_tofree; | |||
| long long mem_freed; /* May be negative */ | |||
| long long mem_freed = 0; /* May be negative */ | |||
There was a problem hiding this comment.
but it is initialized to 0 in line 566,
if need we also need to delete line 566 at the same time.
i'm not sure we need to bother it, although looks werid.
btw: the reason for it being initialized on a separate line: 4a140d3
shahsb
suggested changes
Mar 4, 2024
| @@ -545,7 +545,7 @@ int performEvictions(void) { | |||
|
|
|||
| int keys_freed = 0; | |||
| size_t mem_reported, mem_tofree; | |||
| long long mem_freed; /* May be negative */ | |||
| long long mem_freed = 0; /* May be negative */ | |||
| mstime_t latency, eviction_latency; | |||
| long long delta; | |||
| int slaves = listLength(server.slaves); | |||
There was a problem hiding this comment.
Please remove mem_freed = 0 from line 566
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix evict.c mem_freed variable init, Prevent unknown behavior