Code Review - Behaviors of FixedRate and FixedDelay should be similar in TasksRunnerService #5147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in TasksRunnerService Signed-off-by: Guozhang Wu <wguozhang@vmware.com>
mrniko
requested changes
Jul 4, 2023
…in TasksRunnerService Signed-off-by: Guozhang Wu <wguozhang@vmware.com>
…in TasksRunnerService Signed-off-by: Guozhang Wu <wguozhang@vmware.com>
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
TasksRunnerService, the behaviors of FixedRate and FixedDelay are quite different.In method
scheduleWithFixedDelay, we (1) executeRunnable, and then (2) check whether the task request id still exists, and finally (3) schedule next execution.However, in method
scheduleAtFixedRate, we (1) executeRunnable, and then (2) schedule next execution, without checking the task request id.I believe that
FixedDelayandFixedRateare similar and should not have such difference, so I raise this pull request to add a check in methodscheduleAtFixedRate.This pull request also addresses issue #5143 .