Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PESDLC-876 Add Filehandlers to boto3 loggers #18491

Merged
merged 2 commits into from
May 24, 2024
Merged

Conversation

savex
Copy link
Contributor

@savex savex commented May 14, 2024

 This adds FileHandlers to boto3 loggers using
 the same filenames and levels that is used in ducktape

 Also, adds the logger name manually to easily identify
 the source of the message next to the module name

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

     This adds FileHandlers to boto3 loggers using
     the same filenames and levels that is used in ducktape

     Also, adds the logger name manually to easily identify
     the source of the message next to the module name
@savex savex requested review from abhijat and gousteris May 14, 2024 23:45
Co-authored-by: Solonas Gousteris <44735249+gousteris@users.noreply.github.com>
@savex savex requested a review from gousteris May 17, 2024 15:42
@savex savex merged commit 361aeb2 into dev May 24, 2024
17 checks passed
@savex savex deleted the PESDLC-876-enable-boto3-logging branch May 24, 2024 21:03
@vbotbuildovich
Copy link
Collaborator

/backport v24.1.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.3.x

@vbotbuildovich
Copy link
Collaborator

/backport v23.2.x

@vbotbuildovich
Copy link
Collaborator

Failed to create a backport PR to v23.2.x branch. I tried:

git remote add upstream https://github.com/redpanda-data/redpanda.git
git fetch --all
git checkout -b backport-pr-18491-v23.2.x-973 remotes/upstream/v23.2.x
git cherry-pick -x ee77491f10ca68daf1f316f7a351c4382ce2b1fe 69d8579e2c1aacb0d5963b74a6eec79888e155ba

Workflow run logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants