Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Rust ABI stubs to match wasmtime expectations in runtime. #18529

Closed
wants to merge 1 commit into from
Closed

Adjust Rust ABI stubs to match wasmtime expectations in runtime. #18529

wants to merge 1 commit into from

Conversation

voutilad
Copy link
Contributor

Fixes #18528

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

Bug Fixes

  • Adjust Rust Schema Registry ABI stubs to match expected symbols names.

@github-actions github-actions bot added the area/wasm WASM Data Transforms label May 16, 2024
@oleiman oleiman self-requested a review May 16, 2024 18:52
oleiman
oleiman approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For posterity: it is still not ideal that we don't have integration tests or example code for the Rust SDK SR packages. That work is planned https://redpandadata.atlassian.net/browse/CORE-2951

@oleiman oleiman self-assigned this May 19, 2024
@oleiman
Copy link
Member

oleiman commented May 20, 2024

@voutilad - Added an integration test here: #18555
And pulled your commit onto the front, we can merge it here or there, whatever you prefer.

@voutilad
Copy link
Contributor Author

@oleiman fine by me if you merge your PR with integration test that includes my commit. If you do just close this one.

@oleiman
Copy link
Member

oleiman commented May 20, 2024

@oleiman fine by me if you merge your PR with integration test that includes my commit. If you do just close this one.

sg. thanks (again?) for your help on these

@oleiman oleiman closed this May 21, 2024
@oleiman
Copy link
Member

oleiman commented May 21, 2024

#18555 merged including this change, so closing out this PR

@voutilad voutilad deleted the fix-rust-sr-abi branch May 31, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleiman oleiman oleiman approved these changes

Assignees

@oleiman oleiman

@voutilad voutilad

Labels
area/wasm WASM Data Transforms
Projects
None yet
Milestone
No milestone
2 participants
@voutilad @oleiman