[CORE-1478] rptest: fix retention value in archive_retention_test
#18567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `retention_value` for `retention.bytes` in `archive_retention_test.test_delete` was being set to a value of `1KiB` by default. Sometimes, a segment smaller than `1KiB` would be produced, and thus would not be garbage collected. The `retention_value` is now set using the minimum segment size to ensure all segments are properly deleted per the expectations of the test.
abhijat
approved these changes
May 17, 2024
|
/ci-repeat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
retention_valueforretention.bytesinarchive_retention_test.test_deletewas being set to a value of1KiBby default. Sometimes, a segment smaller than1KiBwould be produced, and thus would not be garbage collected.The
retention_valueis now set using the minimum segment size to ensure all segments are properly deleted per the expectations of the test.Fixes #13841.
Backports Required
Release Notes