Fixed page listing error: comparison of Fixnum with nil failed #3308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When browsing at http://localhost:3000/refinery/pages Pages translated to locales not mentioned in the Refinery::I18n.frontend_locales causes: ``` ArgumentError in Refinery::Admin::Pages#index Showing .../refinerycms-pages-3.0.5/app/views/refinery/admin/pages/_page.html.erb where line refinery#28 raised: comparison of Fixnum with nil failed ``` This happens if you start translating into a language, but remove the locale from Refinery::I18n.frontend_locales if it is not ready at launch.
| @@ -25,7 +25,7 @@ | |||
|
|
|||
| <% if Refinery::I18n.frontend_locales.many? %> | |||
| <span class='locales'> | |||
| <% page.translations.sort_by{ |t| Refinery::I18n.frontend_locales.index(t.locale)}.each do |translation| %> | |||
| <% page.translations.sort_by{ |t| Refinery::I18n.locales.index(t.locale)}.each do |translation| %> | |||
There was a problem hiding this comment.
I like this change but we should really change the locale switcher the way we add the locales edit links. Perhaps we should create a presenter. Thoughts @parndt ?
There was a problem hiding this comment.
It would also be nice if the webmaster could add and remove frontend languages, without requiring a deployment.
There was a problem hiding this comment.
I'm not sure if we want this, perhaps it's a good idea to ask a dev if we can add/remove a frontend language.
|
Is it possible to have a test case for this patch please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When browsing at http://localhost:3000/refinery/pages
Pages translated to locales not mentioned in the Refinery::I18n.frontend_locales causes:
This happens if you start translating into a language, but remove the locale from Refinery::I18n.frontend_locales if it is not ready at launch.