-
-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Typescript type for config (closes #1052) #1055
base: main
Are you sure you want to change the base?
Conversation
Thanks @JohnCampionJr! I'm happy to merge it, but is there a way to automate the generation of the |
There probably is but I’m not sure how without moving everything to
typescript. This is more of a stop-gap.
…On Sat, Nov 11, 2023 at 7:59 AM Lars Kappert ***@***.***> wrote:
Thanks @JohnCampionJr <https://github.com/JohnCampionJr>! I'm happy to
merge it, but is there a way to automate the generation of the
types/config.d.ts file?
—
Reply to this email directly, view it on GitHub
<#1055 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAILJJBPGJWBI6JOGDD7US3YD5ZCJAVCNFSM6AAAAAA6YFMMGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBWHAYTANZUGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Would it be possible to also add brief instructions on 1 of the README so it would be easier for discovery. Thanks |
I've added a bit to the config docs |
Could this PR please be rebased from main? I'm seeing unrelated changes too. |
Looks like you just did that; I don't see any unrelated changes any more either. |
And how about adding it to Definitely Typed? Inspired by JoshuaKGoldberg/release-it-action#29 |
Also, I think that the command line arguments (constructor arguments) could include type declarations as well, since they can affect release-it as well. example: |
I only added the Config; typing the whole project would only be useful for plugin authors and would be a much larger project.
Sample ts config: