-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port make-frame-visible
.
#1573
base: master
Are you sure you want to change the base?
Port make-frame-visible
.
#1573
Conversation
Looks good on first read. With CI being busted currently one of us needs to try it out locally. |
match self.current { | ||
None => None, | ||
Some(window) => { | ||
self.current = window.next.as_valid_window(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The window is not checked for validity in the original make_frame_visible_1
, so you can just call .as_window()
@@ -691,6 +695,36 @@ pub fn frame_face_alist(frame: LispFrameLiveOrSelected) -> LispObject { | |||
frame_ref.face_alist | |||
} | |||
|
|||
/// Update the display_time slot of the buffers shown in WINDOW and all its descendants. | |||
fn make_frame_visible_1(window: LispWindowRef) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function should preferably be a closure inside that make_frame_visible
Resurrect PR (#1526) and port
make-frame-visible
. Fixed the failing tests and made it more rusty.