-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port string #1585
base: master
Are you sure you want to change the base?
Port string #1585
Conversation
A6GibKm
commented
Aug 24, 2020
•
edited
edited
Fails with
|
Add tests
Similar to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly perfect!
let n = args.len(); | ||
let mut buffer = vec![0_u8; n * MAX_MULTIBYTE_LENGTH]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let n = args.len(); | |
let mut buffer = vec![0_u8; n * MAX_MULTIBYTE_LENGTH]; | |
let mut buffer = vec![0_u8; args.len() * MAX_MULTIBYTE_LENGTH]; |
did this because I see nowhere else n
is used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n
is used in make_string_from_bytes
.