Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): edit dialog on "edit-dialog" from "extension-link" stories disappears #2243

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ivan-Perez
Copy link

@Ivan-Perez Ivan-Perez commented Feb 28, 2024

The popup does not appear if the floating wrapper is rendered outside the editor. Probably there's some bug somewhere, but for now this fixes it in the storybook.

Description

There's some issue on this story from the storybook: https://remirror.vercel.app/?path=/story/extensions-link--edit-dialog

The popup does not appear when trying to edit the link (click on the link, then on the "pencil" icon). The popup appears, but immediately disappears.

That only happens if the floating wrapper is rendered outside the editor. Probably there's some bug somewhere, but for now this PR just fixes it in the storybook.

Checklist

  • I have read the contributing document.
  • My code follows the code style of this project and pnpm fix completed successfully.
  • I have updated the documentation where necessary.
  • New code is unit tested and all current tests pass when running pnpm test.

Screenshots

Screencast.from.28-02-24.13.47.17.webm

The popup does not appear if the floating wrapper is rendered outside the editor. Probably there's some bug somewhere, but for now this fixes it in the storybook.
Copy link

changeset-bot bot commented Feb 28, 2024

⚠️ No Changeset found

Latest commit: 02aea00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Ivan-Perez Ivan-Perez changed the title Fix "edit-dialog" on "extension-link" storybook fix(storybook): Edit dialog on "edit-dialog" from "extension-link" stories disappears Feb 28, 2024
@Ivan-Perez Ivan-Perez changed the title fix(storybook): Edit dialog on "edit-dialog" from "extension-link" stories disappears fix(storybook): edit dialog on "edit-dialog" from "extension-link" stories disappears Feb 28, 2024
@rajat1saxena
Copy link

This fixes the issue. However, the floating input box gets clipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants