-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pip-compile): Provide credentials for registries in all input files #28959
base: main
Are you sure you want to change the base?
feat(pip-compile): Provide credentials for registries in all input files #28959
Conversation
Pip-compile can compile multiple input files into one lock file. Renovate calls the manager's `updateArtifacts` function once for each input file, but currently it only looks for private package registries in the input file currently being processed. This changes it to look for them in all of the input files.
@@ -47,11 +47,9 @@ export function cleanRegistryUrls(registryUrls: string[]): string[] { | |||
}); | |||
} | |||
|
|||
export function extractPackageFile( | |||
export function extractPackageFileFlags( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would prefer to move this to a common.ts
and directly import, so it's not a member of the public manager api.
Maybe we should do this as a refactor before this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened #29360
Move the matchManager function to common.ts since it will be used in artifacts.ts in renovatebot#28959
The pip-compile manager will need to extract flags from pip requirements files in renovatebot#28959, so move that code into a common.ts
Changes
Pip-compile can compile multiple input files into one lock file. Renovate calls the manager's
updateArtifacts
function once for each input file, but currently it only looks for private package registries in the input file currently being processed. This changes it to look for them in all of the input files.Context
#28958
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: