Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parallel iterators in attribute processors #4999

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Feb 1, 2024

At least on my machine, the parallel iterators that were recently added to the attribute processing methods result in at least an order of magnitude performance loss.

With par_iter:
image

Without par_iter:
image

(Screenshots taken from #5000)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

@teh-cmc teh-cmc added 📉 performance Optimization, memory use, etc exclude from changelog PRs with this won't show up in CHANGELOG.md labels Feb 1, 2024
@emilk
Copy link
Member

emilk commented Feb 1, 2024

Oh no, these we're very helpful for #4991 but, I guess I'll cross that bridge when I get back to it. Maybe with a "if large, use rayon, else don't" 🙄

It really makes me wish we had benchmarks for this though 😭

@teh-cmc teh-cmc merged commit 4897b93 into main Feb 1, 2024
42 of 47 checks passed
@teh-cmc teh-cmc deleted the cmc/no_parallelism_in_attr_processors branch February 1, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 📉 performance Optimization, memory use, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants