Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove datagen #6152

Merged
merged 4 commits into from May 2, 2024
Merged

Remove datagen #6152

merged 4 commits into from May 2, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Apr 29, 2024 •
edited by github-actions bot

finally

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 🔨 testing testing and benchmarks 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Apr 29, 2024
Wumpf
Wumpf approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good riddance!

@teh-cmc teh-cmc merged commit f7a1808 into main May 2, 2024
23 of 27 checks passed
@teh-cmc teh-cmc deleted the cmc/datagen_ded branch May 2, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality 🔨 testing testing and benchmarks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Awkward datagen module needs to go away
2 participants
@teh-cmc @Wumpf