Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix not being able to click suggestions in space origin selection dropdown #6200

Merged
merged 2 commits into from
May 2, 2024
Merged

Fix not being able to click suggestions in space origin selection dropdown #6200

merged 2 commits into from
May 2, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented May 2, 2024 •
edited by github-actions bot

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🪳 bug Something isn't working ui concerns graphical user interface include in changelog labels May 2, 2024
@abey79 abey79 self-requested a review May 2, 2024 14:41
abey79
abey79 approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. TIL ControlFlow

@emilk emilk merged commit ffb935c into main May 2, 2024
37 checks passed
@emilk emilk deleted the emilk/fix-origin-dropdown branch May 2, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working include in changelog ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking on suggestion does not select it
2 participants
@emilk @abey79