-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Folder structure for code snippets #6219
Conversation
Deployed docs
|
lots of things failing, including webpage build |
5abffed
to
f5ad582
Compare
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/9005576258 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this used to be a symlink which means it was linking to a thing that was threotically being round-trip-tested. I'm not seeing a mechanism that causes that to be the case now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, does anything even use this anymore? Didn't we get rid of embedded quick starts in the viewer?
…nippet_output fine with arbitrary subdirs
had to do some bigger changes: the toml wasn't valid for |
It really looks like |
(do not merge until main ci is green with this) |
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/9019277110 |
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/9019636152 |
What
(either someone fell victim to a github glitch, or really liked creating issues about this 😄)
The compare snippet script needed quite a bit of love to make this work.
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.