Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup usage of unwrap() in re_data_store #6334

Merged
merged 2 commits into from
May 16, 2024

Conversation

Artxiom
Copy link
Contributor

@Artxiom Artxiom commented May 15, 2024

What

Part of #6330
Removes or explicitly allows unwrap() where it makes sense.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

Cargo.toml Outdated Show resolved Hide resolved
crates/re_data_store/src/store_read.rs Outdated Show resolved Hide resolved
@emilk
Copy link
Member

emilk commented May 15, 2024

thanks!

@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 15, 2024
@Artxiom Artxiom changed the title Cleanup usage of unsafe() in re_data_store Cleanup usage of unwrap() in re_data_store May 15, 2024
@Artxiom
Copy link
Contributor Author

Artxiom commented May 16, 2024

@emilk As I don't have write access - how do you guys handle usually external contributions? Do I need to check the other boxes or do anything else, or will you take over from here?

@emilk
Copy link
Member

emilk commented May 16, 2024

Our CI for external contributors is slightly broken: #1994

The checkboxes you have control over though

@emilk emilk changed the title Cleanup usage of unwrap() in re_data_store Cleanup usage of unwrap() in re_data_store May 16, 2024
@emilk emilk merged commit 692b6b6 into rerun-io:main May 16, 2024
31 of 35 checks passed
@Artxiom
Copy link
Contributor Author

Artxiom commented May 16, 2024

Haha, okay.

I just meant what are the guideline for the checkboxes? The first two are obvious but when is it necessary to e.g. test the web demos or when to add something to the checklist, what's a good PR title, etc? And I can't change the labels anyway.
So should I always just leave the remaining checkboxes unchecked or just check them all?

And thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants