Remove unused deps #1521
Merged
Remove unused deps #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 16, 2024
tillrohrmann
approved these changes
May 17, 2024
There was a problem hiding this comment.
Thanks for the cleanup work @AhmedSoliman. Did you use some tooling to find the unused dependencies (udeps or so)? LGTM. +1 for merging.
| @@ -80,7 +80,6 @@ async-channel = "2.1.1" | |||
| async-trait = "0.1.73" | |||
| axum = "0.6.18" | |||
| base64 = "0.21" | |||
| bincode = { version = "2.0.0-rc", default-features = false, features = ["std", "serde", ] } | |||
|
Yes, I used cargo udeps. |
AhmedSoliman
force-pushed
the
pr1521
branch
2 times, most recently
from
72e08eb
to
cb87d88
Compare
This PR includes: - Attachment of PPM to cluster controller now use Networking - PPM observes partition processor status through a buffered watch mechanism - PPM can now send control messages (unused at this PR) to processor for future use. - PPM collects state information from running processors. This will be used in a follow PR to response to controller requests about partitions. Cluster controller grpc service is kept for external tooling integration (CLI, etc.)
ClusterState is a new data structure maintained by ClusterController. ClusterState is established by a scatter-gather request (GetProcessorsState) to all workers. For every worker, partition processor manager is the entity responsible for responding to GetProcessorsState requests, it keeps taps on running partition processors via a set of tokio watches. This PR is a snapshot in time of progress done on this component, this is far from complete but it's best to merge the current progress until we circle back to it in a week or two.
This also changes the loglet API to accept Bytes to avoid duplication of serialization across loglet implementations. This holds the current invariant that payloads are opaque to loglets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused deps
Stack created with Sapling. Best reviewed with ReviewStack.