Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just a notification on external changes #85

Open
wants to merge 254 commits into
base: main
Choose a base branch
from
Open

Conversation

dasmy
Copy link
Contributor

@dasmy dasmy commented Mar 8, 2024

Hi @ricklamers,
This PR is definitely nothing you would want to merge right away and is not intended as such. I would rather like to make you aware about further developments that originated from your great project. If you are interested on how thinks stand in this fork, you might want to watch the video linked in the README.md

In case you are interested, I am definitely open to supporting merging back stuff into your repo. However, commits on my side grew pretty organically, so might be a bit of effort if you want a cleaner history :-)

dasmy and others added 30 commits July 26, 2023 23:31
…al env

TODO: file up- and download does not work yet due to the 'workspace' dir not being mapped correctly
…g as we do not implement multi-user-support. For this, things are prepared, though.
only try to run code if code has been found
…al env

TODO: file up- and download does not work yet due to the 'workspace' dir not being mapped correctly
…g as we do not implement multi-user-support. For this, things are prepared, though.
We first create a base venv that is not to be deleted and can be re-used easily.
There we install all default packages.

Then, we create another, kernel-specific, venv without any additional packages.
Instead, we create a link that points to the packages installed in the base image.

The base image is intended to stay immutable. All newly installed packages end up
in the kernel-specific venv. While they are lost on restart, the packages inside the
base image are not.
…) from rdkit as well (should work for all PIL.Image content, I think)
There is no real documentation on which difference this makes, but at least semantically, this is correct.
…eaks up-/download for now, as the name of the workspace dir should be 'kernel.session_id' instead of 'kernel.workspace'
dasmy and others added 17 commits March 8, 2024 09:38
… time

This should fix crashes where the flusher thread and the flush request from execute() hit the message queue at the same time:

2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61 Bad address (src/fq.cpp:87)
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61 Fatal Python error: Aborted
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61 Thread 0x00007feecd1fe6c0 (most recent call first):
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/enum.py", line 688 in __new__
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/enum.py", line 385 in __call__
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/zmq/sugar/socket.py", line 807 in recv_multipart
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/jupyter_client/channels.py", line 219 in _recv
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/jupyter_client/channels.py", line 230 in get_msg
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/jupyter_client/client.py", line 147 in _async_get_iopub_msg
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/asyncio/events.py", line 80 in _run
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/asyncio/base_events.py", line 1909 in _run_once
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/asyncio/base_events.py", line 603 in run_forever
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/asyncio/base_events.py", line 636 in run_until_complete
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/jupyter_core/utils/__init__.py", line 165 in wrapped
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/backendbuild/gpt_code_ui/kernel_program/kernel.py", line 191 in flush_kernel_msgs
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/backendbuild/gpt_code_ui/kernel_program/kernel.py", line 277 in execute
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/backendbuild/gpt_code_ui/kernel_program/main.py", line 67 in handle_request
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/backendbuild/gpt_code_ui/kernel_program/main.py", line 55 in wrapper
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1469 in dispatch_request
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 1484 in full_dispatch_request
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 2190 in wsgi_app
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 2213 in __call__
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/werkzeug/serving.py", line 323 in execute
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/werkzeug/serving.py", line 362 in run_wsgi
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/http/server.py", line 421 in handle_one_request
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/http/server.py", line 433 in handle
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/werkzeug/serving.py", line 390 in handle
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/socketserver.py", line 747 in __init__
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/socketserver.py", line 360 in finish_request
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/socketserver.py", line 683 in process_request_thread
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/threading.py", line 953 in run
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/threading.py", line 1016 in _bootstrap_inner
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/threading.py", line 973 in _bootstrap
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61 Current thread 0x00007feebebfd6c0 (most recent call first):
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/zmq/sugar/poll.py", line 104 in poll
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/zmq/sugar/socket.py", line 1046 in poll
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/jupyter_client/channels.py", line 228 in get_msg
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/jupyter_client/client.py", line 147 in _async_get_iopub_msg
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/asyncio/events.py", line 80 in _run
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/asyncio/base_events.py", line 1909 in _run_once
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/asyncio/base_events.py", line 603 in run_forever
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/asyncio/base_events.py", line 636 in run_until_complete
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/jupyter_core/utils/__init__.py", line 165 in wrapped
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/backendbuild/gpt_code_ui/kernel_program/kernel.py", line 191 in flush_kernel_msgs
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/backendbuild/gpt_code_ui/kernel_program/kernel.py", line 26 in run
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/threading.py", line 1016 in _bootstrap_inner
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/threading.py", line 973 in _bootstrap
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61 Thread 0x00007feebf5fe6c0 (most recent call first):
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/threading.py", line 324 in wait
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/threading.py", line 607 in wait
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/jupyter_client/channels.py", line 130 in _async_run
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/asyncio/events.py", line 80 in _run
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/asyncio/base_events.py", line 1909 in _run_once
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/asyncio/base_events.py", line 603 in run_forever
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/asyncio/base_events.py", line 636 in run_until_complete
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/jupyter_client/channels.py", line 149 in run
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/threading.py", line 1016 in _bootstrap_inner
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/threading.py", line 973 in _bootstrap
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61 Thread 0x00007feecdbff6c0 (most recent call first):
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/threading.py", line 324 in wait
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/threading.py", line 607 in wait
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/jupyter_client/channels.py", line 130 in _async_run
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/asyncio/events.py", line 80 in _run
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/asyncio/base_events.py", line 1909 in _run_once
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/asyncio/base_events.py", line 603 in run_forever
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/asyncio/base_events.py", line 636 in run_until_complete
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/jupyter_client/channels.py", line 149 in run
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/threading.py", line 1016 in _bootstrap_inner
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/threading.py", line 973 in _bootstrap
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61 Thread 0x00007feedbfff6c0 (most recent call first):
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/threading.py", line 324 in wait
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/threading.py", line 607 in wait
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/backendbuild/gpt_code_ui/kernel_program/stoppable_thread.py", line 19 in stopped
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/backendbuild/gpt_code_ui/kernel_program/main.py", line 24 in run
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/threading.py", line 1016 in _bootstrap_inner
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/threading.py", line 973 in _bootstrap
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61 Thread 0x00007feeedafdb80 (most recent call first):
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/selectors.py", line 416 in select
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/socketserver.py", line 232 in serve_forever
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/werkzeug/serving.py", line 806 in serve_forever
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/werkzeug/serving.py", line 1109 in run_simple
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/site-packages/flask/app.py", line 889 in run
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/backendbuild/gpt_code_ui/kernel_program/main.py", line 109 in main
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/backendbuild/./gpt_code_ui/main.py", line 28 in run_kernel_program
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/multiprocessing/process.py", line 108 in run
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/multiprocessing/process.py", line 314 in _bootstrap
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/multiprocessing/popen_fork.py", line 71 in _launch
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/multiprocessing/popen_fork.py", line 19 in __init__
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/multiprocessing/context.py", line 281 in _Popen
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/multiprocessing/context.py", line 224 in _Popen
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/usr/local/lib/python3.10/multiprocessing/process.py", line 121 in start
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/backendbuild/./gpt_code_ui/main.py", line 36 in start_subprocess
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/backendbuild/./gpt_code_ui/main.py", line 61 in <dictcomp>
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/backendbuild/./gpt_code_ui/main.py", line 61 in main
2024-02-29T14:00:00.138000+00:00 main/app-trgru1vrfqwe3gsa-main/6eca48b23f6a483686be776fadae1f61   File "/backendbuild/./gpt_code_ui/main.py", line 96 in <module>
@ricklamers
Copy link
Owner

This is sick! ❤️

@ricklamers
Copy link
Owner

ricklamers commented Mar 8, 2024

3D woah

Screenshot 2024-03-08 at 3 33 04 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants