Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime: Fix renaming a reconciling resource #4927

Merged
merged 1 commit into from
May 20, 2024
Merged

Runtime: Fix renaming a reconciling resource #4927

merged 1 commit into from
May 20, 2024

Conversation

begelundmuller
Copy link
Contributor

Fixes two issues that sometimes occurs when a resource is renamed while it is reconciling:

  • The resource would no longer exist when the previous reconcile finished, leading to stopping of the controller
  • The rename would start reconciling before the reconciler invocation for the previous name had completed

@begelundmuller begelundmuller self-assigned this May 17, 2024
@begelundmuller begelundmuller added the blocker A release blocker issue that should be resolved before a new release label May 20, 2024
@begelundmuller begelundmuller merged commit 2aba8ca into main May 20, 2024
6 checks passed
@begelundmuller begelundmuller deleted the begelundmuller/fix-rename-reconciling-race branch May 20, 2024 12:40
begelundmuller added a commit that referenced this pull request May 21, 2024
@begelundmuller
Runtime: Fix renaming a reconciling resource (#4927)
95a2127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-anshul k-anshul k-anshul approved these changes

Assignees

@begelundmuller begelundmuller

Labels
blocker A release blocker issue that should be resolved before a new release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@begelundmuller @k-anshul