feat(storage): add metrics for iter_log #16658
Conversation
| ); | ||
|
|
||
| let iter_in_progress_counts = register_guarded_int_gauge_vec_with_registry!( |
There was a problem hiding this comment.
Prior to this PR, this is protected via RelabeledCounterVec but this PR removes it. Is this expected?
There was a problem hiding this comment.
The corresponding metrics of iter_in_process_counts in this PR is iter_counts, which is still protected by RelabeledCounterVec.
This is actually newly added metrics that monitors existing on going iterators of each table. Not sure if we should expose it in per table granularity to observe the existing number of iterators of each table.
| ) | ||
| .unwrap(); | ||
|
|
||
| let iter_log_op_type_counts = register_guarded_int_counter_vec_with_registry!( |
There was a problem hiding this comment.
Do we want to expose this metric in per table granularity by default? If not, we can use RelabeledCounterVec.
There was a problem hiding this comment.
Only the tables that call iter_log will create a new label on this metrics, which is expected to be few, with just mv tables that enable log store. So I think it's fine to expose the metrics in per table granularity so that we can get more insights about the log table.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add metrics for
iter_loginMonitoredStateStore.The code of
MonitoredStateStoreIteris refactored so that we can reuse most monitoring code ofiter. Besides the original metric ofiter, we also add counter to measure the number of insert, update delete initer_logvalue.A metrics that monitoring existing concurrent iter is added by the way in this PR.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.