feat: support pg service & pg meta backend in risedev using docker #16662
+266
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You don't need to fix typo, it'll be fixed in #16663 |
st1page
reviewed
May 9, 2024
xxchan
changed the title
xxchan
reviewed
May 10, 2024
xxchan
reviewed
May 10, 2024
yezizp2012
force-pushed
the
feat/risedev-support-pg-meta-backend
branch
from
a9efa0f
to
3079434
Compare
xxchan
approved these changes
May 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
9 tasks
yezizp2012
added
the
need-cherry-pick-release-1.9
yezizp2012
added a commit
that referenced
this pull request
May 17, 2024
BugenZhao
reviewed
May 21, 2024
| } | ||
| "postgres" => { | ||
| let pg_config = config.provide_postgres_backend.as_ref().unwrap(); | ||
| assert_eq!(pg_config.len(), 1); |
There was a problem hiding this comment.
Will this assertion fail if we specify multiple postgres services in a profile? For example, one is used for CDC test while the other is for the metadata.
There was a problem hiding this comment.
Yes, it's possible. Let me give it a try and fix it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
After this PR, we can start risingwave using pg meta backend as well:
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.