Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: bind create source #16665

Merged
merged 8 commits into from May 14, 2024
Merged

refactor: bind create source #16665

merged 8 commits into from May 14, 2024

Conversation

st1page
Copy link
Contributor

@st1page st1page commented May 9, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  1. the create table with (connector = 'xxx') and create source with (connector = 'xxx') write a lot duplicate code. This PR introduce fn bind_create_source(...) -> Result<(SourceCatalog, DatabaseId, SchemaId)> to reuse the code.
  2. the gen_table_plan_inner() used for create table with conn and create table (as) includes some code for bind the source. This PR move this part into bind_create_source
  3. after 2, the gen_table_plan_inner() will not return the source catalog, so the code path for create table (as) do not need to handle it.
  4. At the same time, the 2 makes it possible to reuse the gen_table_plan_inner when create table from CDC source

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

owner: session.user_id(),
info: source_info,
row_id_index,
with_properties: with_properties.into_inner().into_iter().collect(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will try to refactor the with_properties in another PR.

Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

@st1page st1page added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit b7006a5 May 14, 2024
27 of 28 checks passed
@st1page st1page deleted the sts/refactor_bind_create_source branch May 14, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants