New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(streaming): adapt backfill rate limit according to barrier latency #16678
base: main
Are you sure you want to change the base?
Conversation
a407270
to
07e0d11
Compare
The default adaptive rate limit strategy doesn't work well when I test it with the high amplification case.
Then we end up having too high a rate limit due to 1 and 2. At that point, when adaptive rate limit kicks in, it's too slow as well, since its barrier latency is high (as rate limit is too high). |
acc0499
to
f4b560f
Compare
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
WIP, I want to properly document the shortcomings first.
We implement the barebones tcp congestion control procedure, as indicated here by @chenzl25:
We have a few test scenarios:
Amplification is medium x100
Backpressure can handle this case well. Adaptive Rate Limit does not have any discernible effect.
Amplification is high x500
Backpressure cannot handle this case, barrier latency fluctuates stably, but is relatively high.
Adaptive Rate Limit can sort of handle this case. The Rate Limit becomes 1, and barrier latency keeps low.
But ideally it can maintain at a higher rate instead of just 1..
Amplification is extremely high x10000
TODO
High barrier latency outside of the current job, in a different parallelism
TODO
Improvements
Perhaps fetch metrics from meta directly?
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.