New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add IO estimation based query mode decider #16696
base: main
Are you sure you want to change the base?
Conversation
… IO is sufficiently high.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A first step toward CBO 😄
I'd like to be cautious. The current state looks more predictable to me. Welcome for comments from more people.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation LGTM
let mut decider = ExecutionModeDecider { | ||
estimated_scan_io_bytes: 0, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to make it a method like Decider::new
.
if let Some(table_stat) = reader | ||
.table_stats() | ||
.table_stats | ||
.get(&batch_seq_scan.core().table_catalog.id().table_id()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Is it possible that there are multiple Scan
node for the same table? Should we deduplicate them when estimating the scan bytes considering block cache?
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.