Prevent duplicate entries in recent projects #2644
Conversation
| @@ -791,5 +791,8 @@ void Configuration::addRecentProject(QString file) | |||
| QStringList files = getRecentProjects(); | |||
| files.removeAll(file); | |||
| files.prepend(file); | |||
There was a problem hiding this comment.
Normally, this should prevent duplicates from appearing at all in the list. Do you know in which case a duplicate actually gets added?
There was a problem hiding this comment.
No I don't actually remember. I didn't do anything special. I reported it to you and forgot to open an issue, so few weeks later I just sent a PR :)
It happened on windows
There was a problem hiding this comment.
Might be related to case-sensitivity then.
There was a problem hiding this comment.
why so? and how the snippet you share is taking care of duplicate entries?
There was a problem hiding this comment.
Before adding any file to the list it does files.removeAll(file); to remove all previous occurences of it.
On Windows, paths are not case sensitive, so if you add a path with different upper/lowercase, it might still refer to the same file but the string is different.
|
What do we do about this PR? @ITAYC0HEN could you please rebase on top of the latest "master" branch? |
Your checklist for this pull request
Detailed description
This PR prevents duplicate entries from being added to the recent projects list
Test plan (required)
open the same projects again and again and inspect that only one entry appears