Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the addressable item list functionality for global varible widget. #3342

Merged
merged 1 commit into from
May 19, 2024

Conversation

karliss
Copy link
Member

@karliss karliss commented May 17, 2024

Your checklist for this pull request

Detailed description

Use the existing context menu with generic actions on objects with address .

Do not use the 3 argument connect method without receiver! https://cutter.re/docs/contributing/code/development-guidelines.html#connecting-qt-signals

Test plan (required)

image

  • confirm that Edit/Delete global variable actions are still in the context menu and work
  • try Show xrefs action

image

Closing issues

closes #3311

@karliss karliss requested a review from XVilka May 18, 2024 16:51
@karliss karliss merged commit 8251f7e into rizinorg:dev May 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Show Xrefs to global" in global variable context menu
2 participants